gaogaotiantian commented on PR #58860: URL: https://github.com/apache/spark/pull/58860#issuecomment-6047090147
Ah, interesting. Okay that makes sense. But it's still a bit weird to have a whole function just to test there's no missing dependency. How about this, let's write a util function to list all dependencies for a certain module - which could be a useful utility in the future. Inside the function, we write a slightly more complicated test case to confirm that `pyspark_base` is always in modules starts with `pyspark-`. So we have a useful util function and the coverage for pyspark base. If we have a "java_base" in the future, we can reuse the function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
