NickJavaDev88 commented on PR #59358: URL: https://github.com/apache/spark/pull/59358#issuecomment-6107042458
Thanks again for the feedback, @gaogaotiantian. I removed the mock-based file and added one small test to test_appsubmit.py (+22 lines, no mocks): it starts the real PySpark shell, which covers lines 41-42 of first_spark_call(). Coverage of traceback_utils.py goes from 85% to 90% with the existing test_context/test_rdd tests plus this one. The remaining lines (31, 69) look unreachable via public APIs, so I left them out. I've reopened the PR; happy to close it if it's still not worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
