LukaZdravic commented on code in PR #59322:
URL: https://github.com/apache/spark/pull/59322#discussion_r4247054383
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2628,6 +2628,7 @@ object LateralJoin {
/**
* A logical plan for as-of join.
+ * @param direction Which matching right row to keep.
Review Comment:
Thanks for suggestion, added!
##########
sql/core/src/test/scala/org/apache/spark/sql/AsOfJoinSortMergeSQLSuite.scala:
##########
@@ -212,6 +213,39 @@ class AsOfJoinSortMergeSQLSuite extends QueryTest
Row(180.15) :: Nil)
}
+ test("MATCH_CONDITION with the right operand written first plans the flipped
direction") {
Review Comment:
Moved and droped, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
