LukaZdravic commented on code in PR #59322:
URL: https://github.com/apache/spark/pull/59322#discussion_r4247059265
##########
sql/core/src/test/scala/org/apache/spark/sql/SortMergeAsOfJoinSuite.scala:
##########
@@ -158,6 +187,39 @@ class SortMergeAsOfJoinSuite extends QueryTest
)
}
+ test("keeps the requested direction when a rewrite puts the right side
first") {
+ val schema = StructType(
+ StructField("ts", IntegerType) ::
+ StructField("val", StringType) :: Nil)
+ val left = spark.createDataFrame(List(Row(10, "a")).asJava, schema)
+ // Pairs of right rows tie on ts. Backward keeps the last row of a tie,
Nearest the first.
Review Comment:
Made a clearer comment, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
