peter-toth commented on PR #59324: URL: https://github.com/apache/spark/pull/59324#issuecomment-6121315606
@HyukjinKwon @viirya thank you for the reviews. Everything is in [0eb44e78ba1](https://github.com/apache/spark/pull/59324/commits/0eb44e78ba139cfaf181e82d29fda059f381af44). - Fixed: the "Otherwise" polarity, the `initialize` javadoc, the interpreted-predicate case in `preparedPredicate`, the `hugeVectorReserveRatio` caveat, and the clause order in `storageFiltersFor`. - Added to the conf doc: one sentence on files without a page index and on `parquet.filter.columnindex.enabled=false`. - Back in: why the reader honors `columnindex.enabled` itself, that a subclass reading its own columns goes through `newColumnReader`, the "bug of ours" note in the splicing catch, why `buildReaderWithStorageFilters` returns an `Option`, and the groups of `output` behind `preparedStorageFilters`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
