nchammas commented on code in PR #59250:
URL: https://github.com/apache/spark/pull/59250#discussion_r4251847126
##########
dev/run-tests.py:
##########
@@ -380,8 +381,17 @@ def run_python_packaging_tests():
run_cmd(command)
-def run_build_tests():
- run_cmd([os.path.join(SPARK_HOME, "dev", "test-dependencies.sh")])
+def run_shell_script_tests(test_modules, stage):
+ shell_script_test_goals = determine_shell_script_test_goals(test_modules,
stage)
+
+ if not shell_script_test_goals:
+ return
+
+ title = f"Running {stage.value} shell script tests"
Review Comment:
Fair point; I've addressed this. Ultimately, I think it will be worth
cleaning up our use of GitHub annotations so that failures are correctly and
consistently extracted to the header section of every build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
