nchammas commented on code in PR #59250:
URL: https://github.com/apache/spark/pull/59250#discussion_r4251870120
##########
dev/sparktestsupport/utils.py:
##########
@@ -154,6 +163,93 @@ def determine_modules_to_test(changed_modules,
deduplicated=True):
)
+def determine_test_goals_for_files(filenames: Iterable[str]) -> TestGoals:
Review Comment:
The problem I was trying to address here is easy validation of the test
selection. We don't have standalone tests for `sparktestsupport`, and because
of that we are IMO overusing doctests to make up the difference.
I've removed this function for now. In a future PR I will try to refactor
`sparktestsupport` so we can add proper test files and relieve some of the
pressure we are putting on doctests to ensure correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
