venkata91 commented on PR #59277: URL: https://github.com/apache/spark/pull/59277#issuecomment-6131717412
> Decision challenge (review 5484484950): can a stale client's stop() close the session that replaced its expired one? Good point. Yes, our clients can keep an old `SparkSession` around after another client reattached. To keep this PR's scope contained, 42cc9b6fbd documents the limitation in the conf doc and `docs/configuration.md`: the old `SparkSession` must not be stopped once another client may have reattached, because `ReleaseSession` does not check the server-side session id. Adding `client_observed_server_side_session_id` to `ReleaseSessionRequest`, with the server skipping a mismatched release, seems like the right fix; I'd like to do it in a follow-up JIRA since it touches the proto and both clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
