viirya commented on PR #59334: URL: https://github.com/apache/spark/pull/59334#issuecomment-6130720849
Thanks again, @dongjoon-hyun. All five are addressed in e44b77f: - Zero is normalized before `Decimal.set`: when negative scales are not allowed, a zero's negative scale is dropped first (`setScale(max(scale, 0))`), so `'0e39'` and `'0e2147483647'` now give precision 1 and scale 0, and `'0.00'` keeps scale 2. Under the legacy negative-scale conf zero is left as is, since a negative scale is valid there. - The fast-fail is now one private helper used by both `fromString` and `fromStringANSI`. - `DecimalSuite` checks the precision and scale of the zero results (the precision assertion fails without the normalization), the zero cast checks moved to `CastSuiteBase`, and the test name has the JIRA prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
