HyukjinKwon commented on PR #59283:
URL: https://github.com/apache/spark/pull/59283#issuecomment-6137381676
Thanks, I checked these on the current head. struct(...) inputs now lower to
a CreateNamedStruct that holds only the surviving values, with no With. The
SimplifyExtractValueOps guard is back, nested updates keep the legacy generated
names, dataType and doGenCode no longer index Lists by position, the lowering
batch is Once again, and the CSE test comments describe the bound-reference
rule. One regression comes from the naming change: the new usePrettyExpression
case asks the failing UpdateFields for its dataType while the type-mismatch
error is being built. A nested path through a non-struct value, such as
$"id".withField("a.b", lit(1)), now throws a ClassCastException instead of an
AnalysisException. Details are in this review.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6128951858","thread_id":"conversation:6128951858","verdict_sha256":"376a843e0801b33f093c16ee386ce4fd6a12672aa472f4cfb03d6ca9bc61f79e"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
