zozo123 commented on PR #59155: URL: https://github.com/apache/spark/pull/59155#issuecomment-6145608874
Independent verification at head `a890090e50da2f7d4957d15f1f8df889c61e47ba` (base `f04e6d60ebf9131fd83f306627697370ef52a309`, stable patch-id `b551ff109720c2a84ba644999ace120da34ef71f`). Verdict is PASS+NOTES. I did not write this change. **Evidence.** - The diff touches 5 files with 73 additions and 20 deletions. It has no Snowflake, StAX, Woodstox, or JDBC version changes, and `sql/core` keeps `snowflake-jdbc-thin` from master (#59319). - `build/sbt "udf-worker-grpc/testOnly *DirectGrpcDispatcherIntegrationSuite" "sql/testOnly org.apache.spark.sql.execution.externalUDF.PlanExternalUDFsSuite"` ran in a clean detached worktree at the head on macOS with JDK 17. Results were 4/4 and 32/32 with 0 canceled. The new test passed in 7.3s. `unit-tests.log` shows two echo workers bound to separate UDS sockets over kqueue, one per partition. - The fork CI run at this head is green ([run 38368287345](https://github.com/zozo123/spark/actions/runs/38368287345)). `sql - other tests` ran the new test on Linux and it passed in 3.4s. - On module selection, a change under `udf/worker/` selected only `udf-worker` at base. At head it selects `sql` and 25 downstream modules. `sql/core` already had a compile-scope dependency on `udf-worker-core`, so this adds an edge the build already had. The udf-worker poms do not depend on sql, so there is no cycle. - GitHub reports MERGEABLE/CLEAN. `git merge-tree` against current master `4c53b2a457b` is clean. The only review thread is resolved, and the earlier Netty-strip finding targeted code this head no longer contains. **Notes.** - Any `udf/worker/` change now runs the sql, hive, and pyspark test lanes. That is correct for the dependency, but it costs more CI time. - The CI log has a non-fatal `POSSIBLE THREAD LEAK` warning for this suite. It lists gRPC's shared daemon pools (`grpc-default-executor-*`, `grpc-shared-destroyer-0`). - PR CI only compiles the new Maven test dependency. The scheduled Maven test jobs will be the first to run this test under Maven. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
