urosstan-db commented on code in PR #59466:
URL: https://github.com/apache/spark/pull/59466#discussion_r4273486912
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/vectorExpressions.scala:
##########
@@ -568,14 +618,7 @@ trait VectorAggregateBase extends ImperativeAggregate
null
} else {
val accBytes = buffer.getBinary(mutableAggBufferOffset + accIndex)
- val dim = getDim(accBytes)
Review Comment:
I also avoided having this copying here, I can leave it for seperate PR, but
I think it is fine to optimize it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
