urosstan-db commented on PR #59466: URL: https://github.com/apache/spark/pull/59466#issuecomment-6205599254
Automated review (Spark Dev) of a2da4ac5e24: no blocking findings were identified. - The kernel refactor moves the float `vector_sum` and `vector_avg` update and merge arithmetic over unchanged and keeps the aggregate buffer layout. - The new double kernel follows the same structure with an 8-byte stride. - `vector_avg` and the non-aggregate vector functions still accept only `ARRAY<FLOAT>`, which matches the scope the author declared. - The new tests exercise both the single-pass update path and the multi-partition merge path for double input. Golden-file updates are consistent with the new accepted-type message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
