DevanshSingh-Ksolves commented on PR #59462: URL: https://github.com/apache/spark/pull/59462#issuecomment-6207960062
@uros-b Following up on the latest review: - The earlier P3 (test and fixture placement) is addressed, and the PR title now has the leading underscore. - CI is green. One earlier run had a single unrelated failure (IsolatedClientLoaderIvySettingsSuite, an Ivy download in sql/hive) that passed on re-run. - On the naming question: I kept INNER_CLASS_ENCODER_UNSUPPORTED with SQLSTATE 0A000, because the message is user-facing and already tells users the cause (no access to the defining scope). Happy to rename it, for example to ENCODER_OUTER_SCOPE_NOT_FOUND, if you prefer. Please take a look whenever you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
