SEPURI-SAI-KRISHNA commented on PR #59573:
URL: https://github.com/apache/spark/pull/59573#issuecomment-6239088347
Not a committer, just read through this one closely and built it at
`69318f692f3`. The fix reads correct to me. Two small notes.
In "We considered the opposite fix ...", the closing "That path is kept
available through the legacy config" reads as if the config gives the
skip-at-NULL semantics that fix would have, but it only changes generated code:
with it set the row is skipped with codegen on, while codegen off still raises.
The precise version is in the first section ("The interpreted path is unchanged
in both modes"), so this is only about that one sentence, which would carry
into the commit message.
On "Join conditions ... are not changed": an inner join pushes the
single-side conjuncts into a `Filter`, so I checked this with a left outer
join, where the condition stays on the join, and the legacy config makes no
difference there. Matches what you describe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
