HwangDongJun commented on code in PR #58187:
URL: https://github.com/apache/spark/pull/58187#discussion_r4310478388
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilderSuite.scala:
##########
@@ -66,6 +66,12 @@ class KubernetesDriverBuilderSuite extends PodBuilderSuite {
test("SPARK-37331: check driver pre kubernetes resource, empty by default") {
val sparkConf = new SparkConf(false)
.set(Config.CONTAINER_IMAGE, "spark-driver:latest")
+ // SPARK-38079: HadoopConfDriverFeatureStep now also contributes a
pre-resource
+ // whenever HADOOP_CONF_DIR is set in the environment the test JVM
inherits, which
+ // would otherwise make this assertion depend on that environment
variable. Exclude
+ // it so this test only exercises the "empty by default" case it is
meant to check.
+ .set(Config.KUBERNETES_DRIVER_POD_EXCLUDED_FEATURE_STEPS.key,
+ "org.apache.spark.deploy.k8s.features.HadoopConfDriverFeatureStep")
Review Comment:
No longer applicable: the feature steps no longer return pre-resources, so
`driverPreKubernetesResources` is empty by default again and the `SPARK-37331`
tests are back to their original form. `HadoopConfDriverFeatureStep` and
`KerberosConfDriverFeatureStep` are unchanged from `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
