HwangDongJun commented on PR #58187: URL: https://github.com/apache/spark/pull/58187#issuecomment-6260253877
Thank you for the review, @dongjoon-hyun. I replied to each of the 15 comments in its thread. Summary of the update: - The order now follows item 5: pre-resources before the gated pod, owner references refreshed as on `master`, post-resources and the conf config map next, and the gate removed last with a strategic merge patch that names it. - That makes the changes to the four feature steps, `KubernetesClientUtils` and their tests unnecessary, so they are reverted and the net change is 6 files. - A pod that sets `spec.nodeName` is not gated, so it keeps the previous flow and can still see the `FailedMount` event. One open question, on item 10: I added `spark.kubernetes.submission.useDriverSchedulingGate` (default `true`) as a way back to the previous flow for submitters without `patch` on pods. If documenting the requirement is enough, I will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
