LukaZdravic commented on code in PR #59591:
URL: https://github.com/apache/spark/pull/59591#discussion_r4315236040
##########
sql/core/src/test/resources/sql-tests/inputs/join-asof-semantics.sql:
##########
@@ -321,3 +321,41 @@ FROM using_left l LEFT ASOF JOIN (using_right r LEFT JOIN
using_keys d USING (k)
SELECT l.lts, d.k
FROM using_left l LEFT ASOF JOIN (using_right r JOIN using_keys d USING (k))
MATCH_CONDITION (l.k <= d.k);
+
+-- FVT-ASOF-2-043: an ASOF JOIN with USING passes up the hidden columns of its
inputs
Review Comment:
Added, thanks!
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/AsOfJoinResolver.scala:
##########
@@ -73,8 +73,15 @@ class AsOfJoinResolver(
Seq(leftNameScope.output, rightNameScope.output)
)
+ // MATCH_CONDITION is resolved a second time below. Keep the hidden column
IDs here too, so a
Review Comment:
Moved, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
