LukaZdravic commented on code in PR #59591:
URL: https://github.com/apache/spark/pull/59591#discussion_r4323325107
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/AsOfJoinResolver.scala:
##########
@@ -140,6 +141,22 @@ class AsOfJoinResolver(
}
}
+ /**
+ * Merges the ID mappings of both sides. It also keeps the IDs of hidden
columns like `d.k`:
+ * `MATCH_CONDITION` is resolved again later, and a copy of the same table
on the other side
+ * must not remap them.
+ */
+ private def mergeChildMappings(leftNameScope: NameScope, rightNameScope:
NameScope): Unit = {
Review Comment:
Great great catch, I fixed the issue that regular JOIN had too, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
