vrjdev commented on code in PR #58016: URL: https://github.com/apache/spark/pull/58016#discussion_r4329460461
########## launcher/src/test/java/org/apache/spark/launcher/FilteredObjectInputStreamSuite.java: ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.launcher; + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.ObjectOutputStream; +import java.io.ObjectStreamClass; + +import org.apache.spark.launcher.testpkg.SubpackageAllowed; +import org.apache.spark.launchermalicious.LauncherPrefixSpoof; +import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.*; + +/** + * Tests for {@link FilteredObjectInputStream} - the SPARK-20922 allow-list + * guarding the launcher's local socket protocol. Covers the security-relevant + * {@code resolveClass} path that previously had zero direct tests. + */ +public class FilteredObjectInputStreamSuite extends BaseSuite { + + @Test + public void testAllowedJavaLangStringIsAccepted() throws Exception { Review Comment: Thanks for checking it by rejecting every class. Replaced the payload with `Long` (`testAllowedJavaLangLongIsAccepted`), which goes through `resolveClass` for `java.lang.Long` and `java.lang.Number`, and added a short comment on why it isn't a `String`. Updated the PR description to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
