dongjoon-hyun commented on code in PR #59663:
URL: https://github.com/apache/spark/pull/59663#discussion_r4339138617
##########
core/src/main/scala/org/apache/spark/TaskContextImpl.scala:
##########
@@ -97,6 +100,17 @@ private[spark] class TaskContextImpl(
*/
@transient @volatile private var listenerInvocationThread: Option[Thread] =
None
Review Comment:
**14. [Nit] `@volatile` is no longer needed on `listenerInvocationThread`**
It came with SPARK-40106 for the unlocked `listenerInvocationThread = None`
in the old catch block, which this PR removes. Every remaining access is under
the `TaskContext` lock, as for `nextListenerInvocationThread` (L108), whose doc
says "Protected by the TaskContext lock". Could this drop `@volatile` and say
the same, unless it stays for the lock-free re-check in item 9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
