viirya commented on PR #59663: URL: https://github.com/apache/spark/pull/59663#issuecomment-6510238497
@dongjoon-hyun Thanks, resolved by merging master. The best-effort `logError` of SPARK-60556 is carried over into the reworked `runListener` and into `invokeTaskPreCompletionListener`, and the `FailingAppender` of both PRs is now one class. Three tests of this PR are removed, because they made a listener failure escape the listener loop through a failing log call, which SPARK-60556 now catches: "an error that escapes the listener loop still releases the invocation", "an error that escapes the holder's listener loop hands the invocation over" and "an error of a failure listener invocation is not hidden by the failure of the listener that started it". The code they covered stays, since an error from the invocation itself, e.g. an `OutOfMemoryError`, can still escape, but nothing reaches it now without injecting such an error. This corrects my reply to item 6: the release at the end of the loop with a waiter is no longer covered. The description says so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
