HwangDongJun commented on code in PR #58187: URL: https://github.com/apache/spark/pull/58187#discussion_r4345309229
########## docs/running-on-kubernetes.md: ########## @@ -56,6 +56,12 @@ you may set up a test cluster on your local machine using * You must have appropriate permissions to list, create, edit and delete [pods](https://kubernetes.io/docs/concepts/workloads/pods/) in your cluster. You can verify that you can list these resources by running `kubectl auth can-i <list|create|edit|delete> pods`. + * In cluster mode, `spark-submit` also needs the `patch` verb on pods: it creates the driver pod with a + [scheduling gate](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-scheduling-readiness/) and removes + the gate once the resources the driver mounts exist. A driver pod whose template sets `spec.nodeName` is not gated. Review Comment: Reworded everywhere to "the resources `spark-submit` creates for the driver, such as its config map": the prerequisites bullet and the configuration row in `docs/running-on-kubernetes.md`, the Pod Spec row, the `Config.scala` doc, the comment on `DRIVER_RESOURCES_SCHEDULING_GATE` in `Constants.scala` and the comment in `Client.run()`. `git grep` finds no "mounts" wording around the gate. The PR title and description use the same wording now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
