HwangDongJun commented on code in PR #58187:
URL: https://github.com/apache/spark/pull/58187#discussion_r4345312660
##########
docs/running-on-kubernetes.md:
##########
@@ -2276,13 +2293,30 @@ See the below table for the full list of pod
specifications that will be overwri
Additional node selectors will be added from the spark configuration to
both executor pods.
</td>
</tr>
+<tr>
+ <td>nodeName</td>
+ <td>Kept as the template sets it</td>
+ <td>
+ A driver pod whose template sets <code>nodeName</code> is created without
the scheduling gate described in
+ <code>spark.kubernetes.submission.useDriverSchedulingGate</code>, because
Kubernetes rejects a pod with both.
+ The kubelet can therefore try to mount the driver's resources before they
exist.
+ </td>
+</tr>
<tr>
<td>restartPolicy</td>
<td><code>"never"</code></td>
<td>
Spark assumes that both drivers and executors never restart.
</td>
</tr>
+<tr>
+ <td>schedulingGates</td>
+ <td>Adds <code>spark.apache.org/driver-resources</code> to driver pods</td>
Review Comment:
All four are done:
- the `schedulingGates` row says Spark adds the gate "unless the pod sets
`nodeName` or `spark.kubernetes.submission.useDriverSchedulingGate` is
`false`", and the `Config.scala` doc and the configuration row mention the
`nodeName` exception;
- the `nodeName` row now comes before `nodeSelector`;
- the check is `kubectl auth can-i <list|create|patch|delete> pods`, which
matches the log hint;
- "a driver pod that sets `spec.nodeName`" replaces "whose template sets",
since the check reads the resolved pod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
