dejankrak-db commented on code in PR #59694:
URL: https://github.com/apache/spark/pull/59694#discussion_r4349559641


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -688,8 +689,13 @@ trait ColumnResolutionHelper extends Logging with 
DataTypeErrorsBase {
     // via `Project.hiddenOutputTag`). We accept that here but tag the 
candidate
     // as `hidden` so the top-level merge in `resolveDataFrameColumn` can 
prefer
     // a regular (p.output) match over hidden (p.metadataOutput) ones.
+    //
+    // A candidate is hidden only if it is not visible via `p.output`. An 
attribute

Review Comment:
   Thanks, updated in 4c90759b989. The comment now states that a candidate 
stays hidden once hidden (`c.hidden`), and is written for the narrowed rule 
from the question below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to