sarutak commented on PR #59708: URL: https://github.com/apache/spark/pull/59708#issuecomment-6343253163
Thanks for the thorough review, @dongjoon-hyun. Items 1 to 3 were real regressions and your analysis was spot on. Pushed 2233a6b. **1, 2, 4**: Added `_unwrap_title()` that strips both `Revert "..."` and `Reapply "..."` in one place, and route all three call sites through it (via `leading_jira_ids`). So the resolve path gets a default id for Reapply PRs again, and the Epic/Umbrella blocker and the match prompt run for Revert/Reapply PRs again. This also fixes the pre-existing gap you noted where the skip-tag check did not see `[MINOR]` in `Reapply "[MINOR]..."`. **3, 6**: On a `ValueError`, `leading_jira_ids` now falls back to `_leading_spark_brackets()`, which collects the run of leading `[SPARK-N]` brackets (stopping at the first non-SPARK bracket, so body ids are still ignored). So `[SPARK-48455][DOCS][MINOR] ...` keeps its id. Docstring updated to describe both the wrapper handling and the fallback. **5**: Added doctests for `Revert "..."` / `Reapply "..."` and for `[SPARK-1234][SQL][MINOR] Fix` on `leading_jira_ids`/`_unwrap_title`/`_leading_spark_brackets`, and changed the `update_jira_for_revert` doctest's body id to a distinct `SPARK-9999` so it actually exercises body-id exclusion. **8**: `Title.jira_ids` now uses `list(dict.fromkeys(...))`. **9**: Dropped the overlapping examples and the `re.findall` comparison from `Title.jira_ids`; kept the examples on `leading_jira_ids`. **7**: One note. I kept `jira_ids = leading_jira_ids(title)` rather than reusing `parsed.jira_ids()`, because `leading_jira_ids` adds the unwrap and parse-failure fallback that `parsed` alone does not have. It does mean the unwrapped title is parsed twice in `update_jira_for_pr` (once for ids, once for tags). Happy to refactor into a single parse-plus-fallback helper returning both if you would prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
