sarutak commented on PR #59708:
URL: https://github.com/apache/spark/pull/59708#issuecomment-6409402518
Thanks, @dongjoon-hyun and @spark-test. Pushed 14e286c.
**19**: `update_jira_for_pr` now normalizes the components of the unwrapped
title through `Component.find` before the skip-tag check, as `main()` does for
ordinary titles, so a wrapped `[FOLLOW-UP]` is skipped like `[FOLLOWUP]`.
`Revert "[SPARK-55313][PYTHON][FOLLOW-UP] Only add condabin to PATH for pip
tests"` (efe9b5335f3) is now skipped, and so is its `Reapply` form; `FOLLOW-UP`
is the only alias of a skip tag in the registry. I added `Revert
"[SPARK-1234][SQL][FOLLOW-UP] Fix"` and its `Reapply` form to the skip-tag
loops, and the description now mentions the alias. Since this PR already
extends the skip to `Reapply` and nested titles, I fixed it here rather than in
a follow-up.
**20**: `update()` now patches `resolve_jira_issue` instead of
`resolve_jira_issues`, and the ordinary-merge loop asserts that `"SPARK-1234"`
reaches it for `[SPARK-1234][SQL] Fix mentions SPARK-9999` (the #59587 shape)
and for `Reapply "[SPARK-1234][SQL] Fix"`. I also restored
`leading_jira_ids('Reapply "[SPARK-1234][SQL] Fix"')` and added
`leading_jira_ids('Revert "Revert "[SPARK-1234][SQL] Fix""')`, as @spark-test
suggested. I had dropped the first as a repeat of an `_unwrap_title` input, but
it was the only `leading_jira_ids` example with a `Reapply` wrapper. I checked
the doctests against mutants of the code: an unwrap in `leading_jira_ids` that
handles only `Revert "`, or only one layer of either wrapper, a skip-tag check
without alias normalization, the old whole-title regex in
`resolve_jira_issues`, and a one-layer `_unwrap_title` each make at least one
doctest fail.
**21**: The `Revert "SPARK-49004"` case now has its own sentence, and the
opening sentence says "each leading JIRA id".
**22**: Switched to the builtin `tuple`; the `typing` import is now
`Iterator, List, Optional`.
All 247 doctests pass, and `ruff check` / `ruff format --check` are clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
