srielau commented on PR #59716: URL: https://github.com/apache/spark/pull/59716#issuecomment-6349620346
Thanks for the review. Addressed in fc4b86d99b8: - CHAR scan padding is now V2 `CHAR_READ_SIDE_PADDING` (dialect opt-in), not SQL `RPAD` - H2/Postgres opt in as `RPAD`; SQL Server uses a NULL-preserving CASE form; Oracle is left out - `IS [NOT] NULL` over `readSidePadding` unwraps to the raw column - Internal `spark.sql.optimizer.pushDownCharReadSidePadding` kill switch - Broader H2 coverage plus docker tests for SQL Server, Postgres, and Oracle (docker not run locally) PR description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
