srielau commented on PR #59716: URL: https://github.com/apache/spark/pull/59716#issuecomment-6369883846
On the two decision challenges: 1. Documented on `JdbcDialect.isSupportedFunction` rather than adding a dedicated capability. Returning true for `CHAR_READ_SIDE_PADDING` means JDBC may compile it as the raw column, so the remote must compare with blank-padded (PAD SPACE) CHAR semantics. Dialects that strip trailing spaces or use a NO PAD collation must not opt in. 2. Following the remote collation is intended. It restores the JDBC CHAR path from before read-side padding wrapped the scan, and it matches how VARCHAR equality is already pushed. The PR description now says that a case- or accent-insensitive remote collation can match rows that Spark-local binary comparison would exclude. We are not adding a binary-collation guard in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
