dongjoon-hyun commented on PR #59749: URL: https://github.com/apache/spark/pull/59749#issuecomment-6370863175
Thank you for the review, @viirya. - I added `l.value != null` to the first case and a test with your example. FYI, the guard alone doesn't protect a backport that drops the `value != null` conditions of `boundExprIds` and `argumentMap`. In that case, your `x` is renamed to the enclosing `a` instead. The new test fails in both cases, so it will catch them in the backports. - I kept `FreeVariableValue` in `HigherOrderFunction` because `CodeGenerator.NoLambdaValue` exists only in `master` and `branch-4.x`. This keeps the backports the same. - The `none` assertion now derives the IDs from the canonical forms and checks that both functions get the same IDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
