urosstan-db commented on code in PR #59671:
URL: https://github.com/apache/spark/pull/59671#discussion_r4377292625
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -357,7 +357,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
dialect.updateExtraColumnMeta(conn, rsmd, i + 1, metadata)
val columnType =
- dialect.getCatalystType(dataType, typeName, fieldSize,
metadata).getOrElse(
+ dialect.getCatalystType(dataType, typeName, fieldSize, metadata,
options).getOrElse(
Review Comment:
This PR looks like very big change since it introduces this new method,
while existing isTimestampNTZ, preferTimestampNanos already uses metadata
mechanism. Can you reuse it, and keep scope of this PR to zoneless timestamp
option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
