aleksandar-trajkovic-db commented on code in PR #59671:
URL: https://github.com/apache/spark/pull/59671#discussion_r4415323307
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -352,13 +352,17 @@ object JdbcUtils extends Logging with SQLConfHelper {
metadata.putBoolean("isSigned", isSigned)
metadata.putBoolean("isTimestampNTZ", options.preferTimestampNTZ)
metadata.putBoolean("preferTimestampNanos", options.preferTimestampNanos)
+ metadata.putBoolean(
+ JDBCOptions.JDBC_ZONELESS_TIMESTAMP_AS_NTZ,
options.zonelessTimestampAsNTZ)
metadata.putLong("scale", fieldScale)
metadata.putString("jdbcClientType", typeName)
dialect.updateExtraColumnMeta(conn, rsmd, i + 1, metadata)
val columnType =
dialect.getCatalystType(dataType, typeName, fieldSize,
metadata).getOrElse(
getCatalystType(dataType, typeName, fieldSize, fieldScale, isSigned,
options))
+ // Only an input to the dialect's type mapping, so keep it out of the
schema.
+ metadata.remove(JDBCOptions.JDBC_ZONELESS_TIMESTAMP_AS_NTZ)
Review Comment:
It could hypothetically bleed from a read with the legacy flag off into a
write under the flag on. Also it fails several tests which assert no additional
metadata survives the table resolution, so it's simpler and safer to just
remove it post schema resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
