srielau commented on PR #59716: URL: https://github.com/apache/spark/pull/59716#issuecomment-6444078594
On the two decision challenges: 1. Remote collation is intended. It restores the JDBC CHAR path from before read-side padding wrapped the scan, and it matches pushed VARCHAR equality. There is no non-binary-collation guard. The SQL migration guide now states the result change (for example SQL Server `SQL_Latin1_General_CP1_CI_AS`). 2. V1 JDBC (`spark.read.jdbc` / `USING jdbc`) is out of this PR. Only JDBC catalog (DSv2) tables are fixed; the description now says that. V1 still evaluates these CHAR filters in Spark because `PushableColumn` matches only attributes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
