spark-test commented on PR #59235:
URL: https://github.com/apache/spark/pull/59235#issuecomment-6455236100
Re-checked the four points from the earlier review at the current head:
- The `databaseInSessionCatalog` scaladoc now names the `SHOW VIEWS IN
spark_catalog AS JSON` input, and a v1 test covers that catalog-only case in
both forms.
- `AS JSON lists user-created views` scopes its assertions with the literal
`Set("v_json_a", "v_json_b")`.
- The current-namespace test switches to a separate database and asserts
that a view that exists only in `default` is not listed.
- `V2: AS JSON lists a view under a nested namespace` asserts
`["ns1","ns2"]`.
All four are addressed.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6434874420","thread_id":"conversation:6434874420","verdict_sha256":"d272f1aee53642ded1de990f70c6897d7a75a7f2454214550910e5528195943d"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
