spark-test commented on PR #59235:
URL: https://github.com/apache/spark/pull/59235#issuecomment-6455235894
On the key name: both work, so this is a judgment call for the committers.
This review leans toward `name`. `SHOW TABLES AS JSON` is the closest sibling
listing command and emits `{"name":...,"namespace":[...],"isTemporary":...}`.
On the session catalog it lists views too, so once this PR merges the same view
would appear under `name` in one output and under `viewName` in the other.
`SHOW TABLES AS JSON` is also already in the v4.3.0 release candidates, so its
`name` key is about to ship, and the two commands can only be aligned cheaply
from this side, before this command ships. Mirroring the tabular `viewName`
column is a reasonable alternative, but `SHOW TABLES AS JSON` already chose not
to mirror its tabular `tableName` column. If you switch, the docs schema, field
table, examples, and the `viewName` lookups in the tests need the same change.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6121510392","thread_id":"conversation:6121510392","verdict_sha256":"d272f1aee53642ded1de990f70c6897d7a75a7f2454214550910e5528195943d"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
