linhongliu-db commented on PR #59881: URL: https://github.com/apache/spark/pull/59881#issuecomment-6485179032
Review comments addressed; ready for another pass. The P1 initialization regression is fixed in [f5dc5b8](https://github.com/apache/spark/commit/f5dc5b85ef1270e61242a410d7c8a118006c92e9): Dataset generators and Hive UDTFs evaluate their initialized child expressions. [ade56ed](https://github.com/apache/spark/commit/ade56ed47641d4791191db186fc830dd5db7c097) retains the direct argument-array loop to avoid an intermediate collection per row. Local SBT validation: 10 MiscExpressionsSuite tests, 12 DataFrameSuite explode tests, and all 59 HiveUDFSuite tests passed, along with relevant Scala style checks. GitHub Build currently reports `ACTION_REQUIRED`; CI validation is still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
