ganeshashree commented on PR #59828: URL: https://github.com/apache/spark/pull/59828#issuecomment-6676229986
Thanks, both points were valid and are fixed. - **CREATE FUNCTION with a nested constructor:** a nested call now counts as a temporary function reference only when the temporary function actually owns it, meaning it comes first in the resolution order. Under the default order, or when a persistent function comes first, these bodies are accepted as on master. Flat calls keep the existing check, tracked in SPARK-60806. - **Auto-generated column names:** `ApplyDefaultCollation` no longer restores `USER_SPECIFIED_CAST`, so column names match master. A rebuilt user cast now gets a separate `Cast.RECOLORED_USER_CAST` tag that only the JSON splice check reads. That rebuild is the only place the user mark is lost, so this needed no other changes. - **Nested shadowing:** keeping the documented behavior. PR description updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
