cloud-fan commented on PR #59828:
URL: https://github.com/apache/spark/pull/59828#issuecomment-6690552481
Thanks for the updates. On nested shadowing: letting a clause-free call with
a nested constructor resolve like the flat call is consistent with how other
functions resolve. One case in the documented behavior still differs from a
flat call: a clause-free JSON_ARRAY, JSON_OBJECT or JSON_QUERY written directly
as another constructor's value always means the built-in. This review raises
it. The CREATE FUNCTION and column-name changes will be checked in the next
review round, once that is settled.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6676229986","thread_id":"conversation:6676229986","verdict_sha256":"f98b378a3caeac508ad7390ef78cf9844c43a041b39d3dc246152e77e6eda18f"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
