Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7043#discussion_r33356702
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -102,6 +106,36 @@ private[spark] case class SSLOptions(
}
}
+ /*
+ * The supportedAlgorithms set is a subset of the enabledAlgorithms that
+ * are supported by the current Java security provider for this protocol.
+ */
+ private val supportedAlgorithms: Set[String] = {
+ var context: Option[SSLContext] = Some(SSLContext.getDefault)
--- End diff --
I find this confusing but maybe I'm missing something. You're allocating a
default here to fall back to, only if there is an exception in the try block?
Is that clearer to set in the exception handling path then? and can this ever
be `None`, so, why `Option`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
