Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7043#discussion_r33409833
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -102,6 +106,36 @@ private[spark] case class SSLOptions(
}
}
+ /*
+ * The supportedAlgorithms set is a subset of the enabledAlgorithms that
+ * are supported by the current Java security provider for this protocol.
+ */
+ private val supportedAlgorithms: Set[String] = {
+ var context: Option[SSLContext] = Some(SSLContext.getDefault)
--- End diff --
I think that's more straightforward yes. When do you get the NPE? is it
more straightforward to just check if protocol is set rather than turn it into
null and then wait for something to barf? or is that not the logic.
So the change here is mostly to remove unsupported algos from the list of
enabled ones? that makes sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
