Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5423#discussion_r33394798
  
    --- Diff: 
yarn/history/src/main/scala/org/apache/spark/deploy/history/yarn/YarnHistoryProvider.scala
 ---
    @@ -0,0 +1,1015 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.history.yarn
    +
    +import java.io.FileNotFoundException
    +import java.net.URI
    +import java.util.Date
    +import java.util.concurrent.LinkedBlockingQueue
    +import java.util.concurrent.atomic.{AtomicLong, AtomicBoolean}
    +import java.util.zip.ZipOutputStream
    +
    +import scala.collection.JavaConversions._
    +
    +import org.apache.hadoop.security.UserGroupInformation
    +import org.apache.hadoop.yarn.api.records.timeline.TimelineEntity
    +import org.apache.hadoop.yarn.conf.YarnConfiguration
    +
    +import org.apache.spark.deploy.SparkHadoopUtil
    +import org.apache.spark.deploy.history.yarn.YarnTimelineUtils._
    +import org.apache.spark.deploy.history.yarn.rest.{JerseyBinding, 
TimelineQueryClient}
    +import org.apache.spark.deploy.history.{ApplicationHistoryInfo, 
ApplicationHistoryProvider, HistoryServer}
    +import org.apache.spark.scheduler.{ApplicationEventListener, 
SparkListenerBus}
    +import org.apache.spark.ui.SparkUI
    +import org.apache.spark.{SparkException, Logging, SecurityManager, 
SparkConf}
    +
    +/**
    + * A  History provider which reads in the history from
    + * the YARN Timeline Service.
    + *
    + * The service is a remote HTTP service, so failure modes are
    + * different from simple file IO.
    + *
    + * 1. Application listings are asynchronous, and made on a schedule, though
    + * they can be forced (and the schedule disabled).
    + * 2. The results are cached and can be retrieved with 
[[getApplications()]].
    + * 3. The most recent failure of any operation is stored,
    + * The [[getLastFailure()]] call will return the last exception
    + * or `None`. It is shared across threads so is primarily there for
    + * tests and basic diagnostics.
    + * 4. Listing the details of a single application in [[getAppUI()]]
    + * is synchronous and *not* cached.
    + * 5. the [[maybeCheckHealth()]] call performs a health check as the 
initial
    + * binding operation of this instance. This call invokes 
[[TimelineQueryClient.healthCheck()]]
    + * for better diagnostics on binding failures -particularly configuration 
problems.
    + * 6. Every REST call, synchronous or asynchronous, will invoke 
[[maybeCheckHealth()]] until
    + * the health check eventually succeeds.
    + * <p>
    + * If the timeline is  not enabled, the API calls used by the web UI
    --- End diff --
    
    nit: extra space in "is  not"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to