Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6796#discussion_r33420628
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/parquet/CatalystSchemaConverter.scala
 ---
    @@ -373,8 +374,10 @@ private[parquet] class CatalystSchemaConverter(
     
           // Spark 1.4.x and prior versions only support decimals with a 
maximum precision of 18 and
           // always store decimals in fixed-length byte arrays.
    +      // Always storing FIXED_LEN_BYTE_ARRAY is thus compatible with spark 
<= 1.4.x, except for
    +      // precisions > 18.
           case DecimalType.Fixed(precision, scale)
    -        if precision <= maxPrecisionForBytes(8) && 
!followParquetFormatSpec =>
    +        if !followParquetFormatSpec =>
    --- End diff --
    
    Nit: Let's join this line and the line above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to