Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7073#discussion_r33424468
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnAccessor.scala ---
@@ -118,17 +112,15 @@ private[sql] object ColumnAccessor {
dup.getInt()
dataType match {
- case IntegerType => new IntColumnAccessor(dup)
- case LongType => new LongColumnAccessor(dup)
- case FloatType => new FloatColumnAccessor(dup)
- case DoubleType => new DoubleColumnAccessor(dup)
case BooleanType => new BooleanColumnAccessor(dup)
case ByteType => new ByteColumnAccessor(dup)
case ShortType => new ShortColumnAccessor(dup)
+ case IntegerType | DateType => new IntColumnAccessor(dup)
--- End diff --
It looks to me that we don't need date and timestamp column
accessor/builder, did I miss something here? @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
