Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7073#discussion_r33429235
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/columnar/ColumnStatsSuite.scala ---
@@ -22,19 +22,19 @@ import
org.apache.spark.sql.catalyst.expressions.InternalRow
import org.apache.spark.sql.types._
class ColumnStatsSuite extends SparkFunSuite {
+ testColumnStats(classOf[BooleanColumnStats], BOOLEAN, InternalRow(true,
false, 0))
--- End diff --
By re-ordering catalyst date type handling, I found we missed boolean type
here. Added.
However, we still miss binary type here, as `BINARY` is not subclass of
`NativeColumnType` but `testColumnStats` only accepts `NativeColumnType`.
I'm wondering if we could make `BINARY` extend `NativeColumnType`, as
`BinaryType` extends `AtomicType`.
cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
