Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7073#discussion_r33429372
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/columnar/ColumnTypeSuite.scala ---
@@ -197,8 +197,8 @@ class ColumnTypeSuite extends SparkFunSuite with
Logging {
}
def testNativeColumnType[T <: AtomicType](
- columnType: NativeColumnType[T],
- putter: (ByteBuffer, T#InternalType) => Unit,
+ columnType: NativeColumnType[T])
+ (putter: (ByteBuffer, T#InternalType) => Unit,
--- End diff --
we can use curry here to infer the type `T#InternalType`, thus no need to
add type parameter explicitly like `testNativeColumnType[IntegerType.type](INT,
_.putInt(_), _.getInt)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
