Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/845#discussion_r13037266
--- Diff:
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala ---
@@ -69,9 +71,25 @@ object GenerateMIMAIgnore {
}
}
}
-
+
+ def classesAnnotationCheck(className: String) = {
+ try {
+ val annotList=mirror
+ .classSymbol(Class.forName(className, false, classLoader))
+ .annotations
+
+ isAnnotationExistClassLevel(annotList)
+ } catch {
+ case _: Throwable => {
+ println("Error determining Annotations: " + className)
+ false
+ }
+ }
+ }
+
for (className <- classes) {
val directlyPrivateSpark = isPackagePrivate(className)
+ val annotationCheck = classesAnnotationCheck(className)
--- End diff --
It might be better to call this something like `val developerApi` to make
it grammatically consistent with the other variables. I.e.
```
if (directlyPrivateSpark || indirectlyPrivateSpark || developerApi)
privateClasses += className
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
