Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/845#discussion_r13037443
--- Diff:
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala ---
@@ -69,9 +71,25 @@ object GenerateMIMAIgnore {
}
}
}
-
+
+ def classesAnnotationCheck(className: String) = {
--- End diff --
This could use some formatting and naming cleanup - the indentation is
weird. Also, it might be better to inline `isAnnotationExistClassLevel` rather
than having its own function.
What about this?
```
def isDeveloperApi(className: String) = {
try {
val clazz = mirror.classSymbol(Class.forName(className, false,
classLoader))
clazz.annotations.exists(_.tpe =:=
unv.typeOf[org.apache.spark.annotation.DeveloperApi])
} catch {
case _: Throwable => {
println("Error determining Annotations: " + className)
false
}
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
