Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33714016
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -111,12 +113,19 @@ private[spark] class BlockManager(
// Client to read other executors' shuffle files. This is either an
external service, or just the
// standard BlockTransferService to directly connect to other Executors.
- private[spark] val shuffleClient = if (externalShuffleServiceEnabled) {
- val transConf = SparkTransportConf.fromSparkConf(conf, numUsableCores)
- new ExternalShuffleClient(transConf, securityManager,
securityManager.isAuthenticationEnabled(),
- securityManager.isSaslEncryptionEnabled())
- } else {
- blockTransferService
+ private[spark] val shuffleClient =
mockShuffleClient.getOrElse(createShuffleClient)
+
+ private def createShuffleClient: ShuffleClient = {
--- End diff --
This doesn't need to be a method. It's probably fine to just do
```
private[spark] val shuffleClient = mockShuffleClient.getOrElse {
if (externalShuffleServiceEnabled) ...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
