Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33714625
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java
---
@@ -138,6 +139,26 @@ public void registerWithShuffleServer(
client.sendRpcSync(registerMessage, 5000 /* timeoutMs */);
}
+ /**
+ * Removes this application from the external shuffle server and
optionally deletes local
+ * files.
+ *
+ * @param host Host of the shuffle server.
+ * @param port Port of the shuffle server.
+ * @param cleanupLocalDirs True if corresponding shuffle files should be
deleted
+ * @throws IOException
+ */
+ public void applicationRemoved(String host,
+ int port,
--- End diff --
This is really strange. When I have a callback called `applicationRemoved`
I would expect to see an appID, not a host and a port. All of that should be
transparent to the caller and handled internally right? The other thing is that
there's already similar logic in
`ExternalShuffleBlockResolver#applicationRemoved`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
