GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/7179
[SPARK-8782] [SQL] Fix code generation for ORDER BY NULL
This fixes code generation for queries containing `ORDER BY NULL`.
Previously, the generated code would fail to compile.
I added a traditional regression test for this issue, plus a much larger
fuzz test built on top of the randomized testing utilities introduced in #7176.
This test failed to uncover any additional bugs in GenerateOrdering but did
manage to discover an interesting corner-case involving NaNs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark generate-order-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7179
----
commit d2b4a4a9a2139b1a6c2be5d1f1aa3d98a6c9ed99
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T03:18:05Z
Add random data generator test utilities to Spark SQL.
commit ab76cbd89bf800d590b7833f5a25c62df4ec2a95
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T04:37:38Z
Move code to Catalyst package.
commit 5acdd5ccf36487ba49815e8e0429f4c99558d427
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T05:15:13Z
Infinity and NaN are interesting.
commit b55875a05e4805cfdf2c3468a6cd50eec6a30578
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T05:23:55Z
Generate doubles and floats over entire possible range.
commit 7d5c13ea39cc0b811cc57b58b4214395026b1432
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T05:40:55Z
Add regression test for SPARK-8782 (ORDER BY NULL)
commit e7dc4fbb7c9e441c4367af7680c3acb42440ef33
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T06:15:49Z
Add very generic test for ordering
commit f9efbb5f317d28f8d38e1de9943fa9f976e8b5e5
Author: Josh Rosen <[email protected]>
Date: 2015-07-02T06:17:28Z
Fix ORDER BY NULL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
